refactor: use ScrollLocker #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/dialog/fua3hb9m8 |
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 98.08% 98.07% -0.02%
==========================================
Files 6 6
Lines 157 156 -1
Branches 46 45 -1
==========================================
- Hits 154 153 -1
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
yoyo837
reviewed
Dec 24, 2020
| @@ -133,6 +133,7 @@ export default function Dialog(props: IDialogChildProps) { | |||
| } | |||
|
|
|||
| // ========================= Effect ========================= | |||
| // eslint-disable-next-line consistent-return | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
末尾加return null 或者 空函数可以消灭这个lint 的disable
|
这个 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.